ci(release): sign build images before e2e gates#457
Merged
Conversation
Signed-off-by: Roel de Cort <roel.decort@adfinis.com>
Signed-off-by: Roel de Cort <roel.decort@adfinis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the release-branch signing fixes back to
mainso the next tag release builds helper images with cosign signatures before release E2E gates run.Also ports the release-tag retry target used for failed draft-release retries, and updates the default operator image verification subject regexp to trust
reusable-build.ymlwhen it runs from release tags.Related Issues
Related to #395.
Ports the release-critical fixes from #446 and #448.
Type of Change
Risk and Compatibility
Low runtime API risk. The security-default change broadens trusted keyless subjects only for this repository's
reusable-build.ymlworkflow when invoked from release tags. Release CI now signs build image digests before downstream verification gates consume them. The manual release-tag retry input is constrained to either the merged release PR commit or the current branch head, and branch-head retries must descend from the release PR merge commit while keeping release files aligned.Verification
git diff --checkbash -n hack/ci/create-release-tag-and-draft.sh./bin/actionlint .github/workflows/reusable-build.yml .github/workflows/release.yml .github/workflows/release-tag.ymlgo test ./internal/port/security ./internal/adapter/securityGH_READ_TOKEN="$(gh auth token)" DRY_RUN=1 REPO=dc-tec/openbao-operator BASE_BRANCH=main TAG_TARGET=release-pr-merge bash hack/ci/create-release-tag-and-draft.shTAG_TARGET=branch-headmake lint-cimake lint-ciReviewer Notes
This intentionally keeps the newer action pins already present on
mainwhile porting the behavior fromrelease-0.2. Thebranch-headtag target is only intended for retrying a failed draft release after landing a release-branch fix before the tag exists.Checklist